Moobien 0 Posted March 27, 2018 Share Posted March 27, 2018 Hey man, love this program for OC, thank you for making it. I am currently on the EnderIO test server helping find bugs for 1.12.2 prior to release and I just got the guys to add OC to the server. So I downloaded the program via the usual wget command. It installed happily onto the computer and detected the reactor with no issues but when it completed calibrating my reactor it crashed. https://imgur.com/a/dbosD Is there anything that our server admin needs to know/do to resolve this? Quote Link to post Share on other sites
ZeroNoRyouki 7 Posted March 27, 2018 Share Posted March 27, 2018 @XyFreak if all goes well, I'm going to release the new API later today or tomorrow Quote Link to post Share on other sites
BrisingrAerowing 12 Posted March 27, 2018 Share Posted March 27, 2018 @Moobien That would be a bug in BRGC. A number passed to format is a decimal number, not an integer as expected. Quote Link to post Share on other sites
Moobien 0 Posted March 27, 2018 Share Posted March 27, 2018 So will this happen regardless of server or single player? Quote Link to post Share on other sites
BrisingrAerowing 12 Posted March 27, 2018 Share Posted March 27, 2018 Pretty much. Quote Link to post Share on other sites
Moobien 0 Posted March 27, 2018 Share Posted March 27, 2018 Is it possible to get the previous version which did not have this bug? Quote Link to post Share on other sites
XyFreak 36 Posted March 27, 2018 Author Share Posted March 27, 2018 I feel like i fixed that one eons ago. What LUA version is your OC CPU set to? It should work with both but...you know.... EDIT: the format one. The third one is something else Quote Link to post Share on other sites
XyFreak 36 Posted March 27, 2018 Author Share Posted March 27, 2018 @Moobien can you please run BRGC without the GUI so you can screenshot the full error? That'd really help. Thanks Quote Link to post Share on other sites
XyFreak 36 Posted March 27, 2018 Author Share Posted March 27, 2018 Ok I just ninja updated BRGC. It's now using the new API but can still use the old one. If one or two ppl could confirm that stuff is still working for you that'd be great. I've also tried to make the "too long without yielding" issue less likely to occur so... there's that. Without knowing what exactly is causing https://i.imgur.com/1eV8hJj.png don't actually want to call it RELEASE! time yet tho. Quote Link to post Share on other sites
Moobien 0 Posted March 27, 2018 Share Posted March 27, 2018 3 hours ago, XyFreak said: I feel like i fixed that one eons ago. What LUA version is your OC CPU set to? It should work with both but...you know.... EDIT: the format one. The third one is something else 3 hours ago, XyFreak said: Ok I just ninja updated BRGC. It's now using the new API but can still use the old one. If one or two ppl could confirm that stuff is still working for you that'd be great. I've also tried to make the "too long without yielding" issue less likely to occur so... there's that. Without knowing what exactly is causing https://i.imgur.com/1eV8hJj.png don't actually want to call it RELEASE! time yet tho. The CPU was default crafted. Will get you a screenshot shortly EDIT: When the'crash' happens it does 1 of 1 things. When I have the reactor that is behind the screen connected it flashes the error and then the screen shows what you see in the new screenshot with no text on it. When it isn't connected (reactor behind me is still connected) you get the error in screenshot 2. I haven't updated and I assume that screenshot 2 is what you were asking for https://imgur.com/a/Tov3D Quote Link to post Share on other sites
ZeroNoRyouki 7 Posted March 28, 2018 Share Posted March 28, 2018 Hi there, I've just uploaded the new version of ER (with the new API) on Curse (it's under review at the moment) Have fun! Tahak 1 Quote Link to post Share on other sites
XyFreak 36 Posted March 28, 2018 Author Share Posted March 28, 2018 @ZeroNoRyouki awesome! thanks @Moobien yeah i'm looking for the issue in screenshot 2. However you ran brgc_gui there which lowered the screens resolution so i can't see the top of the stack trace, which is what i actually need :P. I assure you the error should pop up even without running the GUI so...i need a screenshot for that However I think your explanation gave me a hint to what's going on.... shouldn't happen but might. Lemme take a look. Still, I'd really like a screenshot where brgc_gui never ran / was terminated before the issue occurred Quote Link to post Share on other sites
Moobien 0 Posted March 28, 2018 Share Posted March 28, 2018 Ahhh now I understand will the reactor start being calibrated without the gui being started? EDIT here you go! https://imgur.com/a/cGXkW EDIT2: I was just wondering, could this program be adapted for monitoring only? Namely in that I am building a starship, I want my reactor controlled by a computer in the engineering section but cool would be if that info could also be displayed on the bridge but not controlled on the bridge Quote Link to post Share on other sites
sanovskiy 0 Posted March 29, 2018 Share Posted March 29, 2018 @XyFreak, could you share your repo with this project? I/ve found a problem in active reactor calibration routine. I wish to find exact location of a problem. So I need access to repo so I can fix it and make a merge request with fix. Quote Link to post Share on other sites
SpaceBeeGaming 3 Posted March 29, 2018 Share Posted March 29, 2018 @XyFreak At least in MC 1.7.10 with OC 1.7.2.1166 the program doesn't error when finishing calibration. So it is now usable. Quote Link to post Share on other sites
sanovskiy 0 Posted March 29, 2018 Share Posted March 29, 2018 3 hours ago, SpaceBeeGaming said: @XyFreak At least in MC 1.7.10 with OC 1.7.2.1166 the program doesn't error when finishing calibration. So it is now usable. 1.12.2 with Extreme Reactors Spams errors after calibration of active reactor Quote Link to post Share on other sites
Dreytac 0 Posted March 29, 2018 Share Posted March 29, 2018 Hi! Saw this script on DireWolf's videos. Really love the work you've done it! Unfortunately I'm getting a similar error to Moobien when trying to run your script. This error is occuring during the calibration phase so at the moment it makes the script unusable. Hopefully my screenshot helps confirm the problem. Quote Link to post Share on other sites
XyFreak 36 Posted March 29, 2018 Author Share Posted March 29, 2018 @Moobien Looks like you ran into an OpenOS bug. Please report it to the OpenComputer guys One COULD do that but i won't. For now. @SpaceBeeGaming That's good to hear Quote Link to post Share on other sites
XyFreak 36 Posted March 29, 2018 Author Share Posted March 29, 2018 @sanovskiy I also found the issue thanks to @Dreytacs screenshot. I feel stupid now. My linter even warned me about this... gonna be fixed in a few minutes EDIT: NVM the "few minutes" part, my test world no longer loads... Quote Link to post Share on other sites
payonel 21 Posted March 29, 2018 Share Posted March 29, 2018 what openos bug? 1 hour ago, XyFreak said: @Moobien Looks like you ran into an OpenOS bug. Please report it to the OpenComputer guys One COULD do that but i won't. For now. Quote Link to post Share on other sites
XyFreak 36 Posted March 29, 2018 Author Share Posted March 29, 2018 @payonel The uuid library appears to be accessing bit32, which for whatever reason has not been defined. See here: EDIT: please note that I can NOT reproduce this with version 1.7.1.43 EDIT2: I took a quick look and it appears bit32 has been removed from lua 5.3, so uuid will work in lua 5.2 mode but not 5.3... Quote Link to post Share on other sites
payonel 21 Posted March 29, 2018 Share Posted March 29, 2018 yep, should always require("bit32"), it is not intended to be global (we aren't clearing it from _G in boot). I'll fix in dev. sorry XyFreak 1 Quote Link to post Share on other sites
XyFreak 36 Posted March 29, 2018 Author Share Posted March 29, 2018 Ok the issue has been fixed @Dreytac @sanovskiy, sorry for missing that... that was stupid of me... sanovskiy 1 Quote Link to post Share on other sites
XyFreak 36 Posted March 29, 2018 Author Share Posted March 29, 2018 @payonel sweet I'm glad we're finding real issues now and not just me being supid / jumpy Quote Link to post Share on other sites
payonel 21 Posted March 29, 2018 Share Posted March 29, 2018 http://ci.cil.li/job/OpenComputers-MC1.7.10/1178/ Quote Link to post Share on other sites
